A new free booklet by VisitScotland - "Set in Scotland, A Film Fan’s Odyssey" available here - lots of fascinating trivia. On my browser it's a bit clunky so works better when downloaded.

See also http://www.visitscotland.com/about/arts-culture/films/locations which has some local film location leaflets to browse.